Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM][ECO] Order tabs accordingly based on the Signal types available #191935

Merged
merged 4 commits into from
Sep 3, 2024
Merged

[APM][ECO] Order tabs accordingly based on the Signal types available #191935

merged 4 commits into from
Sep 3, 2024

Conversation

cauemarcondes
Copy link
Contributor

closes #190524

When EEM is disabled: Keeps the standard tab order

Screenshot 2024-09-02 at 17 03 45

When EEM is enabled and Service has APM only signal type: Keeps the standard tab order

Screenshot 2024-09-02 at 17 03 26

When EEM is enabled and Service has APM and Logs Signal types: Keeps the standard tab order

Screenshot 2024-09-02 at 17 03 16

When EEM is enabled and Service has Logs only signal type: Reordering Overview | Logs | dashboard | ...

Screenshot 2024-09-02 at 17 03 03

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Sep 2, 2024
@cauemarcondes cauemarcondes requested a review from a team as a code owner September 2, 2024 16:07
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Sep 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

iblancof
iblancof approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@iblancof iblancof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌🏻

kpatticha
kpatticha reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity

How did we come up with this order? 🤔

@cauemarcondes
Copy link
Contributor Author

How did we come up with this order?

When a service has logs only, all APM tabs will be empty, and as of now, we won't show alerts either. So we decided to pull all tabs that might have data together.

crespocarlos
crespocarlos approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cauemarcondes cauemarcondes enabled auto-merge (squash) September 3, 2024 10:57
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 3, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 0bc1cc2
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191935-0bc1cc2e1838

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1866 1867 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +493.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 5c46dad into elastic:main Sep 3, 2024
23 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 3, 2024
@cauemarcondes cauemarcondes deleted the eco-order-tabs-service-overview branch September 3, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblancof iblancof iblancof approved these changes

@kpatticha kpatticha kpatticha approved these changes

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM][Services] Order tabs accordingly based on the Signal types available
8 participants
@cauemarcondes @elasticmachine @obltmachine @kibana-ci @crespocarlos @kpatticha @iblancof @kibanamachine